REGR: MultiIndex Indexing #35353
Merged
REGR: MultiIndex Indexing #35353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll add tests if nothing breaks. I'm not keen on special casing the base Index method, but overriding _reindex_non_unique maybe overkill. maybe better to revert part of #33691 |
simonjayhawkins
added
Bug
Indexing
|
test failures unrelated, see #34850 so marking as ready for review. whatsnew needed for regression in rc? |
|
Thanks, LGTM.
I don't think so. |
|
mpl issue breaking the docs? |
jreback
approved these changes
Jul 20, 2020
|
rebased and green. since this is for 1.1, I suppose this could be merged even without a firm decision on the branch strategy. |
|
Yep, thanks. |
ebardie
pushed a commit
to ebardie/pandas
that referenced
this pull request
Jul 21, 2020
* REGR: MultiIndex Indexing * add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff